Issue 655533002: Create a dump when an invalid referrer in the network stack is encountered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 655533002: Create a dump when an invalid referrer in the network stack is encountered. (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 2 months ago

Reviewers:
battre

CC:
cbentzel+watch_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Create a dump when an invalid referrer in the network stack is encountered. BUG=422871 R=battre@chromium.org Committed: https://crrev.com/b5680e60d9067d52733a5be67444e78dee8112c5 Cr-Commit-Position: refs/heads/master@{#299273}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/net/chrome_network_delegate.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 8 (1 generated)

battre

actually, are you sure that you want the NOTREACHED as well? Anyway, your call.

6 years, 2 months ago (2014-10-13 08:09:19 UTC) #3

jochen (gone - plz use gerrit)

yes, I want developers to not just ignore this.

6 years, 2 months ago (2014-10-13 08:15:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655533002/1

6 years, 2 months ago (2014-10-13 08:16:21 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-13 08:44:26 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b5680e60d9067d52733a5be67444e78dee8112c5
Cr-Commit-Position: refs/heads/master@{#299273}