Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655433004: Get rid of unnecessary forward declarations in components/autofill/ (Closed)

Created:
6 years, 2 months ago by Sunil Ratnu
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, mkwst+watchlist_chromium.org, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Get rid of unnecessary forward declarations in components/autofill/ Some of the forward declarations and #includes are not necessary. Hence, removing them. Committed: https://crrev.com/f545b90970e6c256024903cff0a5724a90fde0f9 Cr-Commit-Position: refs/heads/master@{#300055}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Incorporated Ilya's review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/browser/content_autofill_driver.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/risk/fingerprint.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/full_wallet_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_items_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_signin_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/form_cache.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/password_generation_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/credit_card.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/name_field.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/password_generator_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_change.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_syncable_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/common/password_form_fill_data.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Sunil Ratnu
Hi Ilya, Please have a look. Thanks! Sunil
6 years, 2 months ago (2014-10-16 09:35:31 UTC) #2
Ilya Sherman
How did you determine that these were unnecessary? Script? Manual inspection? Other? https://codereview.chromium.org/655433004/diff/20001/components/autofill/content/browser/wallet/form_field_error.cc File components/autofill/content/browser/wallet/form_field_error.cc ...
6 years, 2 months ago (2014-10-16 16:53:43 UTC) #4
Sunil Ratnu
On 2014/10/16 16:53:43, Ilya Sherman wrote: > How did you determine that these were unnecessary? ...
6 years, 2 months ago (2014-10-16 18:22:48 UTC) #5
Ilya Sherman
Thanks. Please restore the three "base/logging.h" includes that I've flagged. With that, LGTM. https://codereview.chromium.org/655433004/diff/20001/components/autofill/content/browser/wallet/instrument.cc File ...
6 years, 2 months ago (2014-10-16 18:55:46 UTC) #6
Sunil Ratnu
Thanks for the review Ilya. I've incorporated the suggested changes. https://codereview.chromium.org/655433004/diff/20001/components/autofill/content/browser/wallet/form_field_error.cc File components/autofill/content/browser/wallet/form_field_error.cc (left): https://codereview.chromium.org/655433004/diff/20001/components/autofill/content/browser/wallet/form_field_error.cc#oldcode7 ...
6 years, 2 months ago (2014-10-17 02:46:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655433004/40001
6 years, 2 months ago (2014-10-17 02:46:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 2 months ago (2014-10-17 03:38:55 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 03:39:34 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f545b90970e6c256024903cff0a5724a90fde0f9
Cr-Commit-Position: refs/heads/master@{#300055}

Powered by Google App Engine
This is Rietveld 408576698