Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 655433002: MacViews: Disable PluginDiscovery in views_examples_with_content_exe (Closed)

Created:
6 years, 2 months ago by tapted
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MacViews: Disable PluginDiscovery in views_examples_with_content_exe TransformPathForFeature in child_process_host_impl.cc expects to find `Chromium Helper XX` inside the .app bundle, but views_examples_with_content_exe is a standalone executable. The example app doesn't need plugins so this CL disables plugin discovery to avoid: Check failed: kMacOSName == macos_path.BaseName().value() (MacOS vs. Debug) This occurs when particular pages are loaded in the WebView example, triggered via content::PluginLoaderPosix::LoadPluginsInternal(). The change is made in views_content_client, which affects app_list_demo and views_examples_with_content_exe. BUG=395507 Committed: https://crrev.com/9f1e45ad728dc3a236798f55abb677f473a47097 Cr-Commit-Position: refs/heads/master@{#299392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/views_content_client/views_content_client_main_parts_mac.mm View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tapted
Hi Avi - WDYT? This is currently only used by 2 example exes. Other options ...
6 years, 2 months ago (2014-10-13 22:31:55 UTC) #2
Avi (use Gerrit)
Well, that's one way to do it. My normal argument would be that we should ...
6 years, 2 months ago (2014-10-13 22:37:21 UTC) #3
tapted
:) Thanks avi! On packaging, I agree - if these get much more complicated I'll ...
6 years, 2 months ago (2014-10-13 22:56:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655433002/1
6 years, 2 months ago (2014-10-13 22:57:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 23:36:16 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 23:37:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f1e45ad728dc3a236798f55abb677f473a47097
Cr-Commit-Position: refs/heads/master@{#299392}

Powered by Google App Engine
This is Rietveld 408576698