Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 655403002: Settings: Set 0 height to border and magin of hidden static text (Closed)

Created:
6 years, 2 months ago by tkent
Modified:
6 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Settings: Set 0 height to border and magin of hidden static text This is another followup of crrev.com/297738 and crrev.com/298333. We need to set 0 to border-top, border-bottom, margin-top, and margin-bottom in order that a static text element has no height. BUG=421338 Committed: https://chromium.googlesource.com/chromium/src/+/6339c3ad8fc553d8144661f6492c68a4158aa58b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/options/options_page.css View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
tkent
arv@, would you review this please? This is a follow-up of crrev.com/297738 and crrev.com/298333.
6 years, 2 months ago (2014-10-16 02:09:15 UTC) #2
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/655403002/diff/1/chrome/browser/resources/options/options_page.css File chrome/browser/resources/options/options_page.css (right): https://codereview.chromium.org/655403002/diff/1/chrome/browser/resources/options/options_page.css#newcode323 chrome/browser/resources/options/options_page.css:323: border-bottom: 0 !important; Let the !important race begin!
6 years, 2 months ago (2014-10-16 17:10:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655403002/1
6 years, 2 months ago (2014-10-16 23:20:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 23:54:40 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 23:54:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b24556e740c66d2c87a81dc736546122df0217d
Cr-Commit-Position: refs/heads/master@{#300015}

Powered by Google App Engine
This is Rietveld 408576698