chrome/browser/ui/cocoa/browser_window_controller_private.h - Issue 655393002: mac: Fix a bug where a fullscreened window on Mavericks would be too short.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.h

Issue 655393002: mac: Fix a bug where a fullscreened window on Mavericks would be too short. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from rsesek. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.h ('k') | chrome/browser/ui/cocoa/browser_window_controller_private.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_private.h

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.h b/chrome/browser/ui/cocoa/browser_window_controller_private.h

index d001f1dbb4481c48dfe7c32430dad235bf555002..a38c755851177b70dc007bed2789b9cd39920909 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.h

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.h

@@ -157,6 +157,15 @@

// implementation for more details.

- (void)updateSubviewZOrderHack;

+// There is a bug in Mavericks for applications linked against OSX 10.8 and

+// earlier. The bug requires Screens Have Separate Spaces to be enabled, and

+// for the window to be on a secondary screen. When AppKit Fullscreen is

+// invoked on the window, its final frame is 22pt too short. This method

+// detects when the relevant conditions have been met so that a hack can be

+// applied to fix the size of the window.

+// http://crbug.com/396980

+- (BOOL)shouldUseMavericksAppKitFullscreenHack;

@end // @interface BrowserWindowController(Private)

#endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_