Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 655383002: Revert "Add GetModifiedFiles() function to git_utils." (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common@master
Project:
skiacommon
Visibility:
Public.

Description

Revert "Add GetModifiedFiles() function to git_utils." This reverts commit af1de867422c42855ae54ed3838c62ea445ea6b4. After removing svndiff.py in https://skia.googlesource.com/skia/+/70242ace3b2ed06b33ee5ea5c9ac3aedea89b194, nobody uses this function anymore. R=borenet@google.com Committed: https://skia.googlesource.com/common/+/0f61cb64f6c968319105c5dc3328ff765f06243c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M py/utils/git_utils.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
6 years, 2 months ago (2014-10-16 00:33:08 UTC) #1
borenet
LGTM
6 years, 2 months ago (2014-10-16 12:10:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655383002/1
6 years, 2 months ago (2014-10-19 23:37:49 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-19 23:37:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 0f61cb64f6c968319105c5dc3328ff765f06243c

Powered by Google App Engine
This is Rietveld 408576698