[NaCl SDK] Install libpnacl_irt_shim.a into the correct location.

[NaCl SDK] Install libpnacl_irt_shim.a into the correct location.

After we changed the PNaCl toolchain layout, this library was being installed
to the wrong location. Actually, it was worse -- the directory didn't exist, so
the library was being copied into a file called linux_pnacl/lib-<arch>.

The correct location is now linux_pnacl/translator/<arch>/lib.

BUG=423373
R=sbc@chromium.org

Committed: https://crrev.com/d87ffab4e3cd44b2ad5df4c8360f9525c01c9076
Cr-Commit-Position: refs/heads/master@{#299974}

[binji, 2014-10-15 22:50:27]

I'd like to add a test for this, but I'm not sure where it should go. We removed
the translation step from nacl_llvm.mk, and we'd need a new configuration to be
able to use it anyway.

Any ideas?

[Sam Clegg, 2014-10-15 23:32:47]

Hmm.. so we don't do any ahead of time translation anymore?  I didn't realize
that.  Is that because of the new way the pnacl debugging is done?

lgtm to this change anyway.

https://codereview.chromium.org/655353002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/655353002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:141: def
GetPNaClNativeLib(tcpath, arch):
This function should probably be renamed now.

Also, you could ErrorExit if the path doesn't exist before returning?

[binji, 2014-10-15 23:58:46]

No, we don't do any pre-translation anymore. But as I said before, we should
probably test it somewhere, I'm just not sure where.

https://codereview.chromium.org/655353002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/655353002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:141: def
GetPNaClNativeLib(tcpath, arch):
On 2014/10/15 23:32:47, Sam Clegg wrote:
> This function should probably be renamed now.
> 
> Also, you could ErrorExit if the path doesn't exist before returning?

Done.

[binji, 2014-10-16 20:07:52]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2014-10-16 20:09:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655353002/20001

[commit-bot: I haz the power, 2014-10-16 21:01:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 21:04:59]

Patchset 2 (id:??) landed as
https://crrev.com/d87ffab4e3cd44b2ad5df4c8360f9525c01c9076
Cr-Commit-Position: refs/heads/master@{#299974}