GN: Move configs for single-use Linux packages close to usage

GN: Move configs for single-use Linux packages close to usage

Several configs in the Linux GN build are used in only one place.
Defining these configs in build/config/linux/BUILD.gn makes them
get resolved on all Linux-derived platforms, during both target
builds and host-tool builds. This doesn't work on CrOS, which
does not need or want the packages references by these configs.

gconf is used in multiple places, so moving the config won't work.
Instead, the gconf config is only resolved when building for
a Linux target.

BUG=None
TEST=GN build for Linux and CrOS
R=jamesr

Committed: https://crrev.com/0a9e4ca5dc612260424fe103846af9ae145efcd9
Cr-Commit-Position: refs/heads/master@{#299903}

[jamesr, 2014-10-15 22:46:21]

https://codereview.chromium.org/655343002/diff/1/build/config/linux/BUILD.gn
File build/config/linux/BUILD.gn (right):

https://codereview.chromium.org/655343002/diff/1/build/config/linux/BUILD.gn#...
build/config/linux/BUILD.gn:124: if (current_toolchain == host_toolchain &&
host_toolchain == default_toolchain) {
let's wrap this at 80col

https://codereview.chromium.org/655343002/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/655343002/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:7: import("//build/config/linux/pkg_config.gni")
should only import this on linux

https://codereview.chromium.org/655343002/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:28: pkg_config("gnome_keyring") {
i think this should be in an if (is_desktop_linux) block

[Chris Masone, 2014-10-15 22:52:49]

cmasone@chromium.org changed reviewers:
+ brettw@chromium.org

[Chris Masone, 2014-10-15 22:52:50]

https://codereview.chromium.org/655343002/diff/1/build/config/linux/BUILD.gn
File build/config/linux/BUILD.gn (right):

https://codereview.chromium.org/655343002/diff/1/build/config/linux/BUILD.gn#...
build/config/linux/BUILD.gn:124: if (current_toolchain == host_toolchain &&
host_toolchain == default_toolchain) {
On 2014/10/15 22:46:20, jamesr wrote:
> let's wrap this at 80col

Done.

https://codereview.chromium.org/655343002/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/655343002/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:7: import("//build/config/linux/pkg_config.gni")
On 2014/10/15 22:46:21, jamesr wrote:
> should only import this on linux

Done.

https://codereview.chromium.org/655343002/diff/1/chrome/browser/BUILD.gn#newc...
chrome/browser/BUILD.gn:28: pkg_config("gnome_keyring") {
On 2014/10/15 22:46:20, jamesr wrote:
> i think this should be in an if (is_desktop_linux) block

Done.

[jamesr, 2014-10-15 22:53:47]

lgtm

https://codereview.chromium.org/655343002/diff/20001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/655343002/diff/20001/chrome/browser/BUILD.gn#...
chrome/browser/BUILD.gn:16: if (is_linux) {
nit: might as well make this match the use, which is is_desktop_linux, just to
avoid unnecessary imports

[Chris Masone, 2014-10-15 23:17:49]

cmasone@chromium.org changed reviewers:
+ sky@chromium.org

[Chris Masone, 2014-10-15 23:17:50]

+brett and sky for OWNERS review.

https://codereview.chromium.org/655343002/diff/20001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/655343002/diff/20001/chrome/browser/BUILD.gn#...
chrome/browser/BUILD.gn:16: if (is_linux) {
On 2014/10/15 22:53:46, jamesr wrote:
> nit: might as well make this match the use, which is is_desktop_linux, just to
> avoid unnecessary imports

Done.

[sky, 2014-10-16 00:00:05]

LGTM

[Chris Masone, 2014-10-16 00:11:01]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:13:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655343002/40001

[commit-bot: I haz the power, 2014-10-16 00:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:49:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Chris Masone, 2014-10-16 00:55:47]

Ah, thought sky was an owner for all these files. Brett?

On Wednesday, October 15, 2014, <commit-bot@chromium.org> wrote:

> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
> (http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/17918)
>
> https://codereview.chromium.org/655343002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jamesr, 2014-10-16 00:56:48]

On 2014/10/16 00:55:47, Chris Masone wrote:
> Ah, thought sky was an owner for all these files. Brett?
> 

He is, the bot just barfed:

http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...

clicking again for you.

[jamesr, 2014-10-16 00:56:51]

The CQ bit was checked by jamesr@chromium.org

[Chris Masone, 2014-10-16 00:57:54]

Oh, thanks! I'm on my phone.

On Wednesday, October 15, 2014, <jamesr@chromium.org> wrote:

> On 2014/10/16 00:55:47, Chris Masone wrote:
>
>> Ah, thought sky was an owner for all these files. Brett?
>>
>
>
> He is, the bot just barfed:
>
> http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/17918
>
> clicking again for you.
>
> https://codereview.chromium.org/655343002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-10-16 01:00:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655343002/40001

[commit-bot: I haz the power, 2014-10-16 01:50:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 01:50:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Chris Masone, 2014-10-16 14:46:48]

Hm. I guess Brett's still needed for one of these, per the bot.
Build/config/linux/BUILD.gn I suspect

On Wednesday, October 15, 2014, <commit-bot@chromium.org> wrote:

> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
> (http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/17918)
>
> https://codereview.chromium.org/655343002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2014-10-16 16:36:26]

lgtm

[Chris Masone, 2014-10-16 16:36:50]

The CQ bit was checked by cmasone@chromium.org

[Chris Masone, 2014-10-16 16:37:10]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-10-16 16:37:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655343002/40001

[commit-bot: I haz the power, 2014-10-16 16:40:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-16 16:41:44]

Patchset 3 (id:??) landed as
https://crrev.com/0a9e4ca5dc612260424fe103846af9ae145efcd9
Cr-Commit-Position: refs/heads/master@{#299903}