Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 655323002: webtry: Switch from Go's log package to golang/glog. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org, humper
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

webtry: Switch from Go's log package to golang/glog. BUG=skia:2980 TEST=go get -d && go build webtry.go R=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/ae6d6222b28b1dc045311665edd5193eec192034

Patch Set 1 #

Patch Set 2 : add log_dir flag to daemon args list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M experimental/webtry/setup/sys/webtry_init View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/webtry.go View 33 chunks +41 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
6 years, 2 months ago (2014-10-15 20:28:10 UTC) #1
jcgregorio
On 2014/10/15 20:28:10, tfarina wrote: Should also add --log_dir=/tmp/glog to the command line flags when ...
6 years, 2 months ago (2014-10-15 20:33:27 UTC) #2
tfarina
On 2014/10/15 20:33:27, jcgregorio wrote: > On 2014/10/15 20:28:10, tfarina wrote: > > Should also ...
6 years, 2 months ago (2014-10-15 20:52:00 UTC) #3
jcgregorio
On 2014/10/15 20:52:00, tfarina wrote: > On 2014/10/15 20:33:27, jcgregorio wrote: > > On 2014/10/15 ...
6 years, 2 months ago (2014-10-15 20:56:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655323002/20001
6 years, 2 months ago (2014-10-15 21:52:34 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:59:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as ae6d6222b28b1dc045311665edd5193eec192034

Powered by Google App Engine
This is Rietveld 408576698