Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655313003: Add recreate_skps script (Closed)

Created:
6 years, 2 months ago by borenet
Modified:
6 years, 2 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rename #

Patch Set 3 : Add page sets, make some changes #

Patch Set 4 : Move into 'skp' subdir #

Patch Set 5 : Fix telemetry binaries path #

Patch Set 6 : More fixes #

Patch Set 7 : Roll common deps #

Patch Set 8 : Fix cleanup #

Total comments: 6

Patch Set 9 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3722 lines, -1 line) Patch
M .gitignore View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A tools/skp/page_sets/data/README View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/DOWN-skia_br337_desktop.json View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/FAILING-skia_cnn_nexus10.json View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/FAILING-skia_wordpress_desktop.json View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/LAYERS-skia_yahoonews_desktop.json View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/OLD-skia_desktop_set.json View 1 2 3 1 chunk +132 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/OLD-skia_galaxynexus_set.json View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/OLD-skia_nexus10_set.json View 1 2 3 1 chunk +172 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/TIMINGOUT-skia_transformice_nexus10.json View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/skia_maybe_later_set.json View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A tools/skp/page_sets/other/skia_onlinewsj_nexus10.json View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_amazon_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_androidpolice_nexus10.py View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_baidu_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_blogger_desktop.py View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_booking_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_carsvg_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_chalkboard_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_cnet_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_css3gradients_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_culturalsolutions_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_cuteoverload_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_deviantart_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_digg_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_ebay_desktop.py View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_engadget_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_espn_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_facebook_desktop.py View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_fontwipe_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_forecastio_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_frantzen_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_gamedeksiam_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_gmail_nexus10.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_gmailthread_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_googleblog_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_googlecalendar_nexus10.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_googlehome_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_googleplus_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_googlespreadsheetdashed_desktop.py View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_gspro_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_gws_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_hsfi_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_jsfiddlebigcar_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_jsfiddlehumperclip_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_linkedin_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_mapsvg_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_mercurynews_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_mlb_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_mobilenews_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_mozilla_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_nofolo_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_nytimes_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_oldinboxapp_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_pinterest_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_pokemonwiki_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_pravda_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_rectangletransition_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_sahadan_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_samoasvg_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_sfgate_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_slashdot_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_techmeme_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_tigersvg_desktop.py View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_twitter_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_ukwsj_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_vnexpress_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_weather_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_wikipedia_galaxynexus.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_worldjournal_nexus10.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_wowwiki_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_yahooanswers_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_youtube_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/page_sets/skia_youtubetvvideo_desktop.py View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A tools/skp/recreate_skps.py View 1 2 3 4 5 6 7 8 1 chunk +92 lines, -0 lines 0 comments Download
A tools/skp/webpages_playback.py View 1 2 3 4 5 6 7 8 1 chunk +455 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
borenet
I think this is ready for review. I did a direct copy of the scripts ...
6 years, 2 months ago (2014-10-16 19:18:43 UTC) #2
rmistry
FYI: I reviewed patchset4 against patchset8. That seemed to give the nicest diff. LGTM https://codereview.chromium.org/655313003/diff/140001/tools/skp/recreate_skps.py ...
6 years, 2 months ago (2014-10-17 12:44:50 UTC) #3
borenet
https://codereview.chromium.org/655313003/diff/140001/tools/skp/recreate_skps.py File tools/skp/recreate_skps.py (right): https://codereview.chromium.org/655313003/diff/140001/tools/skp/recreate_skps.py#newcode79 tools/skp/recreate_skps.py:79: pass On 2014/10/17 12:44:50, rmistry wrote: > Lets log ...
6 years, 2 months ago (2014-10-17 13:21:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655313003/160001
6 years, 2 months ago (2014-10-17 13:22:28 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 14:37:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) as dc89ca56e6f33790cda2cd93ad772ca61497346b

Powered by Google App Engine
This is Rietveld 408576698