Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 655303002: Fix an issue that some earlier android versions cannot handle file URI correctly (Closed)

Created:
6 years, 2 months ago by qinmin
Modified:
6 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that some earlier android versions cannot handle file URI correctly For File URI, some earlier android versions (<JB MR2) cannot handle it correctly Convert it to absolute path fixes the issue. For JB MR2 and above devices, we use content URI, so not affected. BUG=423338 Committed: https://crrev.com/9602808d94fc9ff3f32fd064a4b0ec9bcf45542c Cr-Commit-Position: refs/heads/master@{#299795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
6 years, 2 months ago (2014-10-15 18:34:02 UTC) #2
Ted C
lgtm
6 years, 2 months ago (2014-10-15 21:37:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655303002/1
6 years, 2 months ago (2014-10-15 21:50:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 00:37:24 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 00:38:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9602808d94fc9ff3f32fd064a4b0ec9bcf45542c
Cr-Commit-Position: refs/heads/master@{#299795}

Powered by Google App Engine
This is Rietveld 408576698