Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 655293002: Win Video Capture: Check returned AM_MEDIA_TYPE pointer before comparing it. (Closed)

Created:
6 years, 2 months ago by mcasas
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Win Video Capture: Check returned AM_MEDIA_TYPE pointer before comparing it. See crash trace in the bug. BUG=423664 Committed: https://crrev.com/bd35c4823694541a2a63bd194aeb45f2ab7bdd2e Cr-Commit-Position: refs/heads/master@{#299734}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/capture/win/video_capture_device_factory_win.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (4 generated)
mcasas
tommi@/perkj@ PTAL. Plz read: https://code.google.com/p/chromium/issues/detail?id=423664#c1
6 years, 2 months ago (2014-10-15 16:21:43 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/655293002/diff/40001/media/video/capture/win/video_capture_device_factory_win.cc File media/video/capture/win/video_capture_device_factory_win.cc (right): https://codereview.chromium.org/655293002/diff/40001/media/video/capture/win/video_capture_device_factory_win.cc#newcode278 media/video/capture/win/video_capture_device_factory_win.cc:278: if (hr != S_OK || !media_type.get()) { FYI ...
6 years, 2 months ago (2014-10-15 17:23:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655293002/40001
6 years, 2 months ago (2014-10-15 17:24:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years, 2 months ago (2014-10-15 19:05:24 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 19:05:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd35c4823694541a2a63bd194aeb45f2ab7bdd2e
Cr-Commit-Position: refs/heads/master@{#299734}

Powered by Google App Engine
This is Rietveld 408576698