extensions/extensions.gyp - Issue 655273005: Implement AutomationNode.querySelector().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 655273005: Implement AutomationNode.querySelector(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Address review comments and flesh out error and edge case handling Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index 5ca8ca8ffab90db8f47bebc8dceafbf4a8063fcf..98bc8f5ef6fd806efe3c7aeaaf792e0032845fc5 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -836,6 +836,8 @@

# Note: sources list duplicated in GN build.

'renderer/activity_log_converter_strategy.cc',

'renderer/activity_log_converter_strategy.h',

+ 'renderer/api/automation/automation_api_helper.cc',

Devlin 2014/10/30 23:26:53 These should be duplicated in the GN build, I thin

+ 'renderer/api/automation/automation_api_helper.h',

'renderer/api_activity_logger.cc',

'renderer/api_activity_logger.h',

'renderer/api_definitions_natives.cc',