extensions/renderer/BUILD.gn - Issue 655273005: Implement AutomationNode.querySelector().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/BUILD.gn

Issue 655273005: Implement AutomationNode.querySelector(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix heap-use-after-free issue by not keeping a scoped_ptr to automation_api_helper in extension_hel… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/BUILD.gn

diff --git a/extensions/renderer/BUILD.gn b/extensions/renderer/BUILD.gn

index 703ad5f74d7b98e5229d0feb3596a1dfd85614b7..740f329780dbab2db8eb454c35558a5ec08105e8 100644

--- a/extensions/renderer/BUILD.gn

+++ b/extensions/renderer/BUILD.gn

@@ -11,6 +11,8 @@ source_set("renderer") {

sources = [

"activity_log_converter_strategy.cc",

"activity_log_converter_strategy.h",

+ "api/automation/automation_api_helper.cc",

+ "api/automation/automation_api_helper.h",

"api_activity_logger.cc",

"api_activity_logger.h",

"api_definitions_natives.cc",