chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js - Issue 655273005: Implement AutomationNode.querySelector().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js

Issue 655273005: Implement AutomationNode.querySelector(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix heap-use-after-free issue by not keeping a scoped_ptr to automation_api_helper in extension_hel… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/tests/tabs/queryselector.js ('k') | extensions/common/extension_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js

diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js

index 0bf163c13e83d7ebab7122f16eae2d203e502e8a..c14659a2ddf3f8dd42e02c9aa6262731e80ad344 100644

--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js

+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/tab_id.js

@@ -1,3 +1,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

@@ -22,7 +23,7 @@ function assertCorrectTab(rootNode) {

var allTests = [

function testGetTabById() {

- getUrlFromConfig(function(url) {

+ getUrlFromConfig('index.html', function(url) {

// Keep the NTP as the active tab so that we know we're requesting the

// tab by ID rather than just getting the active tab still.

createBackgroundTab(url, function(tab) {