chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js - Issue 655273005: Implement AutomationNode.querySelector().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

Issue 655273005: Implement AutomationNode.querySelector(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix heap-use-after-free issue by not keeping a scoped_ptr to automation_api_helper in extension_hel… Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/sites/index.html ('k') | chrome/test/data/extensions/api_test/automation/tests/tabs/common.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

index 42c769dd253f091c8b86e7ad15a97fe6cc532239..bb2d619b8c05af6f8118e08ed3851d905a2d596a 100644

--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

@@ -4,7 +4,7 @@

var allTests = [

function testCloseTab() {

- getUrlFromConfig(function(url) {

+ getUrlFromConfig('index.html', function(url) {

chrome.tabs.create({'url': url}, function(tab) {

chrome.automation.getTree(function(rootNode) {

rootNode.addEventListener(EventType.destroyed, function() {