Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: chrome/browser/extensions/api/automation/automation_apitest.cc

Issue 655273005: Implement AutomationNode.querySelector(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Fix heap-use-after-free issue by not keeping a scoped_ptr to automation_api_helper in extension_hel… Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/automation_internal/automation_internal_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/automation/automation_apitest.cc
diff --git a/chrome/browser/extensions/api/automation/automation_apitest.cc b/chrome/browser/extensions/api/automation/automation_apitest.cc
index 5d3bd57843e54e7182042964e8205b4254bf9025..8a3dac103cbf3e9dd2f2dd2c5a6c2e379e00afd3 100644
--- a/chrome/browser/extensions/api/automation/automation_apitest.cc
+++ b/chrome/browser/extensions/api/automation/automation_apitest.cc
@@ -57,12 +57,6 @@ class AutomationApiTest : public ExtensionApiTest {
host_resolver()->AddRule("*", embedded_test_server()->base_url().host());
}
- void LoadPage() {
- StartEmbeddedTestServer();
- const GURL url = GetURLForPath(kDomain, "/index.html");
- ui_test_utils::NavigateToURL(browser(), url);
- }
-
public:
virtual void SetUpInProcessBrowserTestFixture() override {
ExtensionApiTest::SetUpInProcessBrowserTestFixture();
@@ -70,7 +64,9 @@ class AutomationApiTest : public ExtensionApiTest {
};
IN_PROC_BROWSER_TEST_F(AutomationApiTest, TestRendererAccessibilityEnabled) {
- LoadPage();
+ StartEmbeddedTestServer();
+ const GURL url = GetURLForPath(kDomain, "/index.html");
+ ui_test_utils::NavigateToURL(browser(), url);
ASSERT_EQ(1, browser()->tab_strip_model()->count());
content::WebContents* const tab =
@@ -177,6 +173,13 @@ IN_PROC_BROWSER_TEST_F(AutomationApiTest, CloseTab) {
<< message_;
}
+IN_PROC_BROWSER_TEST_F(AutomationApiTest, QuerySelector) {
+ StartEmbeddedTestServer();
+ ASSERT_TRUE(
+ RunExtensionSubtest("automation/tests/tabs", "queryselector.html"))
+ << message_;
+}
+
static const int kPid = 1;
static const int kTab0Rid = 1;
static const int kTab1Rid = 2;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/automation_internal/automation_internal_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698