Implement AutomationNode.querySelector().

chrome/common/extensions/api/automation.idl

Index: chrome/common/extensions/api/automation.idl
diff --git a/chrome/common/extensions/api/automation.idl b/chrome/common/extensions/api/automation.idl
index 2c48253a86f695ee4cf2d8bf473f5cb6924041dc..f6c50fe4090065ecfffd511221a59e28c6e15ac7 100644
--- a/chrome/common/extensions/api/automation.idl
+++ b/chrome/common/extensions/api/automation.idl
@@ -220,6 +220,14 @@
     long height;
   };
 
+  // The parameters for a <code>query</code>.
+  dictionary QueryInfo {
+    DOMString? querySelector;

[David Tseng, 2014/10/27 20:44:35]

Is this optional?

[aboxhall, 2014/10/28 23:43:56]

See below.

+  };

[David Tseng, 2014/10/27 20:44:35]

Will there be additional info members? If not, then just expose the query info
as a string.

[aboxhall, 2014/10/28 23:43:56]

Right, I guess my CL description was a little misleading :)

This is the proposed API in the linked bug
(https://code.google.com/p/chromium/issues/detail?id=404710)

/**
 * Gets the first node in this node's subtree which matches |queryInfo|.
 * @param {Object} queryInfo A query object with any of the following keys:
 *  - selector {string} a CSS querySelector string
 *  - state {StateType} for example ‘focused’
 *  - role {RoleType}
 * @return {chrome.automation.AutomationNode}
 */
chrome.automation.AutomationNode.query(query);

This change just implements 'selector' (which I somewhat arbitrarily renamed
querySelector here).

My idea was that we could implement the filters which act over the automation
tree in JavaScript, unless there's some more performant way to do it in C++.

I'd love it if you had any suggestions for other attributes we could query on,
too.

[dmazzoni, 2014/10/29 00:00:10]

My vote is to have two separate APIs. I'll comment on the bug.

+
+  // Called when the result for a <code>query</code> is available.
+  callback QueryCallback = void(AutomationNode node);
+
   // An event in the Automation tree.
   [nocompile, noinline_doc] dictionary AutomationEvent {
     // The $(ref:automation.AutomationNode) to which the event was targeted.
@@ -292,6 +300,8 @@
     // Removes a listener for the given event type and event phase.
     static void removeEventListener(
         EventType eventType, AutomationListener listener, boolean capture);
+

[David Tseng, 2014/10/27 20:44:35]

nit: Docs?

[aboxhall, 2014/10/28 23:43:56]

Done.

+    static void query(QueryInfo info, QueryCallback callback);
   };
 
   // Called when the <code>AutomationRootNode</code> for the page is available.