Implement AutomationNode.querySelector().

extensions/renderer/api/automation/automation_api_helper.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_RENDERER_API_AUTOMATION_AUTOMATION_API_HELPER_H_
+#define EXTENSIONS_RENDERER_API_AUTOMATION_AUTOMATION_API_HELPER_H_
+
+#include <string>
+
+#include "base/strings/string16.h"
+#include "content/public/renderer/render_view_observer.h"
+
+namespace extensions {
+
+class AutomationApiHelper : public content::RenderViewObserver {

[Devlin, 2014/10/28 21:05:10]

document

[aboxhall, 2014/10/28 23:43:57]

Done.

+ public:
+  AutomationApiHelper(content::RenderView* render_view);
+  virtual ~AutomationApiHelper();

[Devlin, 2014/10/28 21:05:10]

nit: ~AutomationApiHelper() override;

[aboxhall, 2014/10/28 23:43:57]

Similarly, I don't understand why.

+
+ private:
+  // RenderViewObserver implementation.
+  virtual bool OnMessageReceived(const IPC::Message& message) override;

[Devlin, 2014/10/28 21:05:10]

nit: no virtual

[aboxhall, 2014/10/28 23:43:57]

Why?

+  void OnQuerySelector(int acc_obj_id,

[Devlin, 2014/10/28 21:05:10]

new line + comments

[aboxhall, 2014/10/28 23:43:57]

Added new line; I don't think I can add any comments which aren't tautological.

+                       int request_id,
+                       const base::string16& selector);
+};

[Devlin, 2014/10/28 21:05:10]

DISALLOW_COPY_AND_ASSIGN

[aboxhall, 2014/10/28 23:43:57]

Done.

+
+}
+#endif  // EXTENSIONS_RENDERER_API_AUTOMATION_AUTOMATION_API_HELPER_H_