Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 655273003: [screen-orientation] Add missing returns after sending error notification. (Closed)

Created:
6 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[screen-orientation] Add missing returns after sending error notification. The issue was found and fixed by jonross@ in https://codereview.chromium.org/648733003/. I moved it away from his CL because he is OOO and it would be better to get this fixed sooner than later. BUG=162827 Committed: https://crrev.com/740d4ba9b72ce129013758a6831ee6ed744ca076 Cr-Commit-Position: refs/heads/master@{#299699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/public/browser/screen_orientation_provider.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mlamouri (slow - plz ping)
6 years, 2 months ago (2014-10-15 15:50:38 UTC) #2
Charlie Reis
Thanks, LGTM.
6 years, 2 months ago (2014-10-15 15:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655273003/1
6 years, 2 months ago (2014-10-15 16:07:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 17:04:15 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 17:05:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/740d4ba9b72ce129013758a6831ee6ed744ca076
Cr-Commit-Position: refs/heads/master@{#299699}

Powered by Google App Engine
This is Rietveld 408576698