Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: Source/devtools/front_end/sources/SourcesPanel.js

Issue 655273002: DevTools: zoom is broken in hosted mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review comments addressed. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/ui/ActionRegistry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/Source/devtools/front_end/sources/SourcesPanel.js b/Source/devtools/front_end/sources/SourcesPanel.js
index 657c5ae28b4c988e0fc653da92b4df135cd71fdc..9036c4d4318430ab1c161c1bb9f4c1d83bec75c3 100644
--- a/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/Source/devtools/front_end/sources/SourcesPanel.js
@@ -708,7 +708,7 @@ WebInspector.SourcesPanel.prototype = {
/**
* @param {string} buttonId
* @param {string} buttonTitle
- * @param {function(!Event=):boolean} handler
+ * @param {function(!Event=)} handler
* @param {!Array.<!WebInspector.KeyboardShortcut.Descriptor>} shortcuts
* @return {!WebInspector.StatusBarButton}
*/
@@ -730,12 +730,9 @@ WebInspector.SourcesPanel.prototype = {
*/
_createButtonAndRegisterShortcutsForAction: function(buttonId, buttonTitle, actionId)
{
- /**
- * @return {boolean}
- */
function handler()
{
- return WebInspector.actionRegistry.execute(actionId);
+ WebInspector.actionRegistry.execute(actionId);
}
var shortcuts = WebInspector.shortcutRegistry.shortcutDescriptorsForAction(actionId);
return this._createButtonAndRegisterShortcuts(buttonId, buttonTitle, handler, shortcuts);
« no previous file with comments | « no previous file | Source/devtools/front_end/ui/ActionRegistry.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698