DevTools: zoom is broken in hosted mode

Source/devtools/front_end/ui/ShortcutRegistry.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {!WebInspector.ActionRegistry} actionRegistry
  */
 WebInspector.ShortcutRegistry = function(actionRegistry)
 {
@@ skipping 75 matching lines @@
      * @param {number} key
      * @param {string} keyIdentifier
      * @param {!KeyboardEvent=} event
      */
     handleKey: function(key, keyIdentifier, event)
     {
         var keyModifiers = key >> 8;
         var actionIds = this.applicableActions(key);
         if (WebInspector.GlassPane.DefaultFocusedViewStack.length > 1) {
             if (actionIds.length && !isPossiblyInputKey())
                 event.consume(true);

[dgozman, 2014/10/16 10:28:17]

drive-by: looks like |event| here may be undefined.

[pfeldman, 2014/10/16 10:46:47]

Done.

             return;
         }
 
-        for (var i = 0; i < actionIds.length; ++i) {
-            if (!isPossiblyInputKey()) {
-                if (handler.call(this, actionIds[i]))
-                    break;
-            } else {
-                this._pendingActionTimer = setTimeout(handler.bind(this, actionIds[i]), 0);
-                break;
+        if (!isPossiblyInputKey())
+            processActionIdsSequentially.call(this);
+        else
+            this._pendingActionTimer = setTimeout(processActionIdsSequentially.bind(this), 0);
+
+        /**
+         * @this {WebInspector.ShortcutRegistry}
+         */
+        function processActionIdsSequentially()
+        {
+            delete this._pendingActionTimer;
+            var actionId = actionIds.shift();
+            if (!actionId)
+                return;
+
+            this._actionRegistry.execute(actionId).then(continueIfNecessary.bind(this));
+
+            /**
+             * @this {WebInspector.ShortcutRegistry}
+             */
+            function continueIfNecessary(result)
+            {
+                if (result) {
+                    if (event)
+                        event.consume(true);

[dgozman, 2014/10/16 10:28:17]

How does this work when consuming event asynchronously?

[dgozman, 2014/10/16 10:41:16]

Let's comment about "best effort" you are doing here.

[pfeldman, 2014/10/16 10:46:46]

Acknowledged.

[pfeldman, 2014/10/16 10:46:47]

Done.

+                    return;
+                }
+                return processActionIdsSequentially.call(this);

[dgozman, 2014/10/16 10:28:17]

nit: processActionIdsSequentially does not return anything.

[pfeldman, 2014/10/16 10:46:47]

It actually does return a Promise.<undefined> that gets chained. Annotated.

[pfeldman, 2014/10/16 10:56:49]

nm, you are right.

             }
         }
 
         /**
          * @return {boolean}
          */
         function isPossiblyInputKey()
         {
             if (!event || !WebInspector.isBeingEdited(/** @type {!Node} */ (event.target)) || /^F\d+|Control|Shift|Alt|Meta|Win|U\+001B$/.test(keyIdentifier))
                 return false;
 
             if (!keyModifiers)
                 return true;
 
             var modifiers = WebInspector.KeyboardShortcut.Modifiers;
             if ((keyModifiers & (modifiers.Ctrl | modifiers.Alt)) === (modifiers.Ctrl | modifiers.Alt))
                 return WebInspector.isWin();
 
             return !hasModifier(modifiers.Ctrl) && !hasModifier(modifiers.Alt) && !hasModifier(modifiers.Meta);
         }
 
         /**
          * @param {number} mod
          * @return {boolean}
          */
         function hasModifier(mod)
         {
             return !!(keyModifiers & mod);
         }
-
-        /**
-         * @param {string} actionId
-         * @return {boolean}
-         * @this {WebInspector.ShortcutRegistry}
-         */
-        function handler(actionId)
-        {
-            var result = this._actionRegistry.execute(actionId);
-            if (result && event)
-                event.consume(true);
-            delete this._pendingActionTimer;
-            return result;
-        }
     },
 
     /**
      * @param {string} actionId
      * @param {string} shortcut
      */
     registerShortcut: function(actionId, shortcut)
     {
         var descriptor = WebInspector.KeyboardShortcut.makeDescriptorFromBindingShortcut(shortcut);
         if (!descriptor)
@@ skipping 54 matching lines @@
  * @constructor
  */
 WebInspector.ShortcutRegistry.ForwardedShortcut = function()
 {
 }
 
 WebInspector.ShortcutRegistry.ForwardedShortcut.instance = new WebInspector.ShortcutRegistry.ForwardedShortcut();
 
 /** @type {!WebInspector.ShortcutRegistry} */
 WebInspector.shortcutRegistry;