Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655273002: DevTools: zoom is broken in hosted mode (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
dgozman, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: zoom is broken in hosted mode BUG=423737 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183808

Patch Set 1 #

Total comments: 9

Patch Set 2 : review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -32 lines) Patch
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 chunks +2 lines, -5 lines 0 comments Download
M Source/devtools/front_end/ui/ActionRegistry.js View 1 2 chunks +6 lines, -5 lines 0 comments Download
M Source/devtools/front_end/ui/ShortcutRegistry.js View 1 2 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pfeldman
6 years, 2 months ago (2014-10-15 15:25:32 UTC) #2
dgozman
https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js File Source/devtools/front_end/ui/ShortcutRegistry.js (right): https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js#newcode96 Source/devtools/front_end/ui/ShortcutRegistry.js:96: event.consume(true); drive-by: looks like |event| here may be undefined. ...
6 years, 2 months ago (2014-10-16 10:28:17 UTC) #3
dgozman
lgtm https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js File Source/devtools/front_end/ui/ShortcutRegistry.js (right): https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js#newcode124 Source/devtools/front_end/ui/ShortcutRegistry.js:124: event.consume(true); On 2014/10/16 10:28:17, dgozman wrote: > How ...
6 years, 2 months ago (2014-10-16 10:41:16 UTC) #4
pfeldman
https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js File Source/devtools/front_end/ui/ShortcutRegistry.js (right): https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js#newcode96 Source/devtools/front_end/ui/ShortcutRegistry.js:96: event.consume(true); On 2014/10/16 10:28:17, dgozman wrote: > drive-by: looks ...
6 years, 2 months ago (2014-10-16 10:46:47 UTC) #5
pfeldman
https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js File Source/devtools/front_end/ui/ShortcutRegistry.js (right): https://codereview.chromium.org/655273002/diff/1/Source/devtools/front_end/ui/ShortcutRegistry.js#newcode127 Source/devtools/front_end/ui/ShortcutRegistry.js:127: return processActionIdsSequentially.call(this); nm, you are right.
6 years, 2 months ago (2014-10-16 10:56:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655273002/20001
6 years, 2 months ago (2014-10-16 10:57:24 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 12:09:40 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183808

Powered by Google App Engine
This is Rietveld 408576698