Script streaming: fix small script recognition heuristic.

Script streaming: fix small script recognition heuristic.

It can happen that the first data chunk for a large script is small. To handle
this, we don't give up with streaming immediately when we receive a small data
chunk, but simply delay the decision to start the streaming.

See crbug.com/425475 for discussion about when this can happen.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184201

[marja, 2014-10-22 12:14:41]

marja@chromium.org changed reviewers:
+ haraken@chromium.org

[marja, 2014-10-22 12:14:41]

haraken, ptal

[haraken, 2014-10-22 14:20:39]

https://codereview.chromium.org/655263003/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptStreamer.cpp (right):

https://codereview.chromium.org/655263003/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptStreamer.cpp:280: if
(resource->resourceBuffer()->size() < kSmallScriptThreshold) {

What happens if the kSmallScriptThreshold is 1 KB and you receive a 10 MB script
in a sequence of 500 byte chunks? Then m_haveEnoughDataForStreaming won't become
true forever.

I guess you need to count the accumulated size of received data and compare the
accumulated size with kSmallScriptThreshold.

[haraken, 2014-10-22 14:25:28]

LGTM

https://codereview.chromium.org/655263003/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptStreamer.cpp (right):

https://codereview.chromium.org/655263003/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptStreamer.cpp:280: if
(resource->resourceBuffer()->size() < kSmallScriptThreshold) {
On 2014/10/22 14:20:39, haraken wrote:
> 
> What happens if the kSmallScriptThreshold is 1 KB and you receive a 10 MB
script
> in a sequence of 500 byte chunks? Then m_haveEnoughDataForStreaming won't
become
> true forever.
> 
> I guess you need to count the accumulated size of received data and compare
the
> accumulated size with kSmallScriptThreshold.

Discussed offline. resource->resourceBuffer()->size() is the accumulated size,
and thus the CL looks great.

[marja, 2014-10-22 14:46:28]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2014-10-22 14:47:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/655263003/20001

[commit-bot: I haz the power, 2014-10-22 17:59:54]

Committed patchset #2 (id:20001) as 184201