Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 655253004: Convert fast/multicol/columns-shorthand-parsing to reftest. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/columns-shorthand-parsing to reftest. * Use standards mode. * Adjust test slightly to make ref easier to make. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184222

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use float, remove -moz. #

Messages

Total messages: 6 (1 generated)
andersr
6 years, 2 months ago (2014-10-20 13:39:31 UTC) #1
mstensho (USE GERRIT)
lgtm, with suggestions. https://codereview.chromium.org/655253004/diff/1/LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html File LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html (right): https://codereview.chromium.org/655253004/diff/1/LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html#newcode8 LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html:8: display: inline-block; Using float:left instead of ...
6 years, 2 months ago (2014-10-20 20:58:47 UTC) #2
andersr
https://codereview.chromium.org/655253004/diff/1/LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html File LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html (right): https://codereview.chromium.org/655253004/diff/1/LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html#newcode8 LayoutTests/fast/multicol/columns-shorthand-parsing-expected.html:8: display: inline-block; On 2014/10/20 20:58:47, mstensho wrote: > Using ...
6 years, 2 months ago (2014-10-21 12:02:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655253004/20001
6 years, 2 months ago (2014-10-22 21:20:11 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 22:26:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184222

Powered by Google App Engine
This is Rietveld 408576698