Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 655243002: Introduce v8::Exception::GetStackTrace API method. (Closed)

Created:
6 years, 2 months ago by aandrey
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev, Paweł Hajdan Jr., ulan
Project:
v8
Visibility:
Public.

Description

Introduce v8::Exception::GetStackTrace API method. This will be needed to get a stack trace from a DOMException. API=v8::Exception::GetStackTrace R=yangguo@chromium.org LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=24655

Patch Set 1 #

Patch Set 2 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M include/v8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
aandrey
6 years, 2 months ago (2014-10-15 14:07:03 UTC) #1
Yang
LGTM, but please include a test case for this in test/cctest/test-api.cc
6 years, 2 months ago (2014-10-15 14:09:50 UTC) #3
aandrey
On 2014/10/15 14:09:50, Yang wrote: > LGTM, but please include a test case for this ...
6 years, 2 months ago (2014-10-15 14:32:55 UTC) #4
Yang
lgtm.
6 years, 2 months ago (2014-10-15 14:35:00 UTC) #5
aandrey
6 years, 2 months ago (2014-10-16 10:42:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24655 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698