components/proximity_auth/bluetooth_connection_unittest.cc - Issue 655143002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/bluetooth_connection_unittest.cc

Issue 655143002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/registry_dict_win.cc ('k') | components/search_engines/template_url_service_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/bluetooth_connection_unittest.cc

diff --git a/components/proximity_auth/bluetooth_connection_unittest.cc b/components/proximity_auth/bluetooth_connection_unittest.cc

index 7eb7a82f9152a8d9ef28eabce45dba137a71a822..80c04e977af4aaa42c00b0bca63a0ae62ede9c6e 100644

--- a/components/proximity_auth/bluetooth_connection_unittest.cc

+++ b/components/proximity_auth/bluetooth_connection_unittest.cc

@@ -406,7 +406,7 @@ TEST_F(ProximityAuthBluetoothConnectionTest,

scoped_ptr<TestWireMessage> wire_message(new TestWireMessage);

EXPECT_CALL(*socket_, Send(_, kSerializedMessageLength, _, _))

.WillOnce(SaveArg<0>(&buffer));

- connection.SendMessage(wire_message.PassAs<WireMessage>());

+ connection.SendMessage(wire_message.Pass());

ASSERT_TRUE(buffer.get());

EXPECT_EQ(kSerializedMessage,

std::string(buffer->data(), kSerializedMessageLength));

@@ -427,7 +427,7 @@ TEST_F(ProximityAuthBluetoothConnectionTest, SendMessage_Success) {

device::BluetoothSocket::SendCompletionCallback callback;

EXPECT_CALL(*socket_, Send(_, _, _, _)).WillOnce(SaveArg<2>(&callback));

- connection.SendMessage(wire_message.PassAs<WireMessage>());

+ connection.SendMessage(wire_message.Pass());

ASSERT_FALSE(callback.is_null());

EXPECT_CALL(connection, OnDidSendMessage(Ref(*expected_wire_message), true));

@@ -449,7 +449,7 @@ TEST_F(ProximityAuthBluetoothConnectionTest, SendMessage_Failure) {

device::BluetoothSocket::ErrorCompletionCallback error_callback;

EXPECT_CALL(*socket_, Send(_, _, _, _)).WillOnce(SaveArg<3>(&error_callback));

- connection.SendMessage(wire_message.PassAs<WireMessage>());

+ connection.SendMessage(wire_message.Pass());

ASSERT_FALSE(error_callback.is_null());

EXPECT_CALL(connection, OnDidSendMessage(Ref(*expected_wire_message), false));