Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d-expected.txt

Issue 655133003: Fix a broken WebGL layout test by using testRunner.displayAsyncThen(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fit indentation to existing code Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d-expected.txt
diff --git a/LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d-expected.txt b/LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d-expected.txt
index ffba91af9fafd5e22ed040370660cff28816231e..a441e9ed49eedb525460d17f1bf683e5a6c5e63b 100644
--- a/LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d-expected.txt
+++ b/LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d-expected.txt
@@ -28,7 +28,7 @@ PASS imgdata[2] is 0
PASS imgdata[0] is 255
PASS imgdata[1] is 0
PASS imgdata[2] is 0
-FAIL imgdata[0] should be 255. Was 0.
-FAIL imgdata[1] should be 0. Was 255.
+PASS imgdata[0] is 255
+PASS imgdata[1] is 0
PASS imgdata[2] is 0
This test checks for drawing webgl to canvas 2d. The test process is as follows: 1. draw a green rect on a webgl context. 2. draw a red rect on a canvas 2d context, and check a pixel (should be red). 3. draw the webgl contents on the canvas 2d context, and check a pixel (should be green). 4. wait for few frames. 5. draw a red rect on the canvas 2d context, and check a pixel (should be red). 6. draw the webgl contents on the canvas 2d context, and check a pixel (see below explanation). Above test is executed for both preserve and non-preserve webgl contexts. For the preserve webgl context, the pixel on #6 is green. For the non-preserve webgl context, the pixel on #6 is undefined.[1] [1] http://www.khronos.org/registry/webgl/specs/latest/1.0/. "This default behavior can be changed by setting the preserveDrawingBuffer attribute of the WebGLContextAttributes object. If this flag is true, the contents of the drawing buffer shall be preserved until the author either clears or overwrites them. If this flag is false, attempting to perform operations using this context as a source image after the rendering function has returned can lead to undefined behavior.".

Powered by Google App Engine
This is Rietveld 408576698