Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 655133003: Fix a broken WebGL layout test by using testRunner.displayAsyncThen(). (Closed)

Created:
6 years, 2 months ago by dshwang
Modified:
6 years, 2 months ago
CC:
blink-reviews, bajones, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix a broken WebGL layout test by using testRunner.displayAsyncThen(). The expected result of fast/canvas/webgl/draw-webgl-to-canvas-2d.html is failure because this test uses setTimeout to go to next frame. testRunner.displayAsyncThen() can fix this test. BUG=423674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183817

Patch Set 1 #

Patch Set 2 : Fit indentation to existing code #

Total comments: 1

Patch Set 3 : Use requestAnimationFrame instead of setTimeout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d.html View 1 2 2 chunks +19 lines, -8 lines 0 comments Download
M LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dshwang
Hi kbr@, could you review?
6 years, 2 months ago (2014-10-15 08:43:13 UTC) #2
Ken Russell (switch to Gerrit)
LGTM overall but one comment. BTW, please include bajones and zmo on WebGL reviews. https://codereview.chromium.org/655133003/diff/20001/LayoutTests/fast/canvas/webgl/draw-webgl-to-canvas-2d.html ...
6 years, 2 months ago (2014-10-16 03:05:03 UTC) #3
dshwang
On 2014/10/16 03:05:03, Ken Russell wrote: > LGTM overall but one comment. BTW, please include ...
6 years, 2 months ago (2014-10-16 12:26:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655133003/40001
6 years, 2 months ago (2014-10-16 12:27:06 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 14:12:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183817

Powered by Google App Engine
This is Rietveld 408576698