Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 655133002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
nasko
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, jdduke+watch_chromium.org, kalyank, mcasas+watch_chromium.org, miu+watch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, sievers+watch_chromium.org, James Su, wjia+watch_chromium.org, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/0ef8964d3f3d0de239f3c28a2a18476340080e8d Cr-Commit-Position: refs/heads/master@{#299739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 24 chunks +26 lines, -26 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-15 17:13:34 UTC) #2
nasko
LGTM
6 years, 2 months ago (2014-10-15 19:07:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655133002/1
6 years, 2 months ago (2014-10-15 19:11:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 19:22:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 19:23:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0ef8964d3f3d0de239f3c28a2a18476340080e8d
Cr-Commit-Position: refs/heads/master@{#299739}

Powered by Google App Engine
This is Rietveld 408576698