Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 655063003: Disconnect frame owners when detaching frames. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, site-isolation-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Disconnect frame owners when detaching frames. BUG=423536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183834

Patch Set 1 #

Patch Set 2 : Rebase on top of frame detach streamlining and add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M Source/core/frame/Frame.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nate Chapin
LGTM Is there anything to test here?
6 years, 2 months ago (2014-10-14 23:41:59 UTC) #2
dcheng
On 2014/10/14 23:41:59, Nate Chapin wrote: > LGTM > > Is there anything to test ...
6 years, 2 months ago (2014-10-15 00:09:26 UTC) #3
haraken
LGTM
6 years, 2 months ago (2014-10-15 00:50:51 UTC) #4
sof
lgtm. fwiw, we haven't come across Oilpan problems with having the owner disconnect happen during ...
6 years, 2 months ago (2014-10-15 12:23:55 UTC) #6
dcheng
PTAL. I've updated this patch on top of japhet@'s latest cleanup patch, eliminated redundant codepaths, ...
6 years, 2 months ago (2014-10-16 00:38:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655063003/20001
6 years, 2 months ago (2014-10-16 18:06:19 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:56:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183834

Powered by Google App Engine
This is Rietveld 408576698