extensions/browser/api/socket/tls_socket.cc - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/tls_socket.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/socket/tls_socket.cc

diff --git a/extensions/browser/api/socket/tls_socket.cc b/extensions/browser/api/socket/tls_socket.cc

index b579a0838bad6f6bf89cd6b35ff6b9e06668982b..9115c7392828fa042f88a800c5f9526d82b3cd40 100644

--- a/extensions/browser/api/socket/tls_socket.cc

+++ b/extensions/browser/api/socket/tls_socket.cc

@@ -78,7 +78,7 @@ TLSSocket::~TLSSocket() {

}

void TLSSocket::Connect(const std::string& address,

- int port,

+ uint16 port,

const CompletionCallback& callback) {

callback.Run(net::ERR_CONNECTION_FAILED);

}

@@ -148,7 +148,7 @@ bool TLSSocket::SetNoDelay(bool no_delay) {

}

int TLSSocket::Listen(const std::string& address,

- int port,

+ uint16 port,

int backlog,

std::string* error_msg) {

*error_msg = kTLSSocketTypeInvalidError;