content/public/common/common_param_traits.cc - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/common_param_traits.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/common_param_traits.cc

diff --git a/content/public/common/common_param_traits.cc b/content/public/common/common_param_traits.cc

index f4f9a0874b5039c40abc4b9efb5247eb9505a0ef..dcdb7cfffcbfe7045afa7efa3652b96ad490ceb4 100644

--- a/content/public/common/common_param_traits.cc

+++ b/content/public/common/common_param_traits.cc

@@ -102,7 +102,7 @@ void ParamTraits<net::IPEndPoint>::Write(Message* m, const param_type& p) {

bool ParamTraits<net::IPEndPoint>::Read(const Message* m, PickleIterator* iter,

param_type* p) {

net::IPAddressNumber address;

- int port;

+ uint16 port;

if (!ReadParam(m, iter, &address) || !ReadParam(m, iter, &port))

return false;

if (address.size() &&