content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc ('k') | content/public/browser/devtools_http_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

index 26c0e44ee34f6277a36309c6dd4b5c2c73a0e4c1..dd915b85ea377e2c152c0a4329dd53c99e2f394f 100644

--- a/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

@@ -257,7 +257,7 @@ void PepperUDPSocketMessageFilter::DoBind(

new net::UDPServerSocket(NULL, net::NetLog::Source()));

net::IPAddressNumber address;

- int port;

+ uint16 port;

if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &address, &port)) {

SendBindError(context, PP_ERROR_ADDRESS_INVALID);

return;

@@ -353,7 +353,7 @@ void PepperUDPSocketMessageFilter::DoSendTo(

memcpy(sendto_buffer_->data(), data.data(), num_bytes);

net::IPAddressNumber address;

- int port;

+ uint16 port;

if (!NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &address, &port)) {

SendSendToError(context, PP_ERROR_ADDRESS_INVALID);

return;