content/browser/renderer_host/p2p/socket_host_test_utils.h - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_test_utils.h

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/p2p/socket_host_test_utils.h

diff --git a/content/browser/renderer_host/p2p/socket_host_test_utils.h b/content/browser/renderer_host/p2p/socket_host_test_utils.h

index acab45ff25fe4073740521a259eb647d8cc6e7d0..b94a2eec92dbf4d3ca95510e2d60881d05b7d97d 100644

--- a/content/browser/renderer_host/p2p/socket_host_test_utils.h

+++ b/content/browser/renderer_host/p2p/socket_host_test_utils.h

@@ -16,9 +16,9 @@

const char kTestLocalIpAddress[] = "123.44.22.4";

const char kTestIpAddress1[] = "123.44.22.31";

-const int kTestPort1 = 234;

+const uint16 kTestPort1 = 234;

const char kTestIpAddress2[] = "133.11.22.33";

-const int kTestPort2 = 543;

+const uint16 kTestPort2 = 543;

class MockIPCSender : public IPC::Sender {

public:

@@ -91,7 +91,7 @@ void CreateStunRequest(std::vector<char>* packet);

void CreateStunResponse(std::vector<char>* packet);

void CreateStunError(std::vector<char>* packet);

-net::IPEndPoint ParseAddress(const std::string ip_str, int port);

+net::IPEndPoint ParseAddress(const std::string ip_str, uint16 port);

MATCHER_P(MatchMessage, type, "") {

return arg->type() == type;