Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert bad change Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/nacl_process_host.cc
diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc
index afb430aabf7e5f73798bf266361b38d17eedd99e..8994ad68ecea34ed63ca7ca7e0d8ef2ca4b9f149 100644
--- a/components/nacl/browser/nacl_process_host.cc
+++ b/components/nacl/browser/nacl_process_host.cc
@@ -757,7 +757,7 @@ void NaClProcessHost::SetDebugStubPort(int port) {
#if defined(OS_POSIX)
// TCP port we chose for NaCl debug stub. It can be any other number.
-static const int kInitialDebugStubPort = 4014;
+static const uint16_t kInitialDebugStubPort = 4014;
net::SocketDescriptor NaClProcessHost::GetDebugStubSocketHandle() {
net::SocketDescriptor s = net::kInvalidSocket;
@@ -765,7 +765,7 @@ net::SocketDescriptor NaClProcessHost::GetDebugStubSocketHandle() {
// allocate any available port.
// On success, if the test system has register a handler
// (GdbDebugStubPortListener), we fire a notification.
- int port = kInitialDebugStubPort;
+ uint16 port = kInitialDebugStubPort;
s = net::TCPListenSocket::CreateAndBind("127.0.0.1", port);
if (s == net::kInvalidSocket) {
s = net::TCPListenSocket::CreateAndBindAnyPort("127.0.0.1", &port);
« no previous file with comments | « chromecast/browser/devtools/remote_debugging_server.cc ('k') | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698