chrome/test/chromedriver/net/websocket.cc - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/websocket.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/net/websocket.cc

diff --git a/chrome/test/chromedriver/net/websocket.cc b/chrome/test/chromedriver/net/websocket.cc

index 2c214f9c1494c96cc0b95ef4f8b2ad901b5058b4..d62f7fba9809e5e270836e9608e38a5088b3871d 100644

--- a/chrome/test/chromedriver/net/websocket.cc

+++ b/chrome/test/chromedriver/net/websocket.cc

@@ -78,9 +78,8 @@ void WebSocket::Connect(const net::CompletionCallback& callback) {

return;

}

- int port = 80;

- base::StringToInt(url_.port(), &port);

- net::AddressList addresses(net::IPEndPoint(address, port));

+ net::AddressList addresses(

+ net::IPEndPoint(address, static_cast<uint16>(url_.EffectiveIntPort())));

net::NetLog::Source source;

socket_.reset(new net::TCPClientSocket(addresses, NULL, source));