Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4385)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert bad change Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/testing_browser_process.cc ('k') | chrome/test/chromedriver/net/port_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index db45a69f43a1cd0d37353a020907cddfb9141f79..adbe51c544d4e91fedafed9b777a9992097ead33 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -85,7 +85,7 @@ Status UnpackAutomationExtension(const base::FilePath& temp_dir,
return Status(kOk);
}
-Status PrepareCommandLine(int port,
+Status PrepareCommandLine(uint16 port,
const Capabilities& capabilities,
CommandLine* prepared_command,
base::ScopedTempDir* user_data_dir,
@@ -268,7 +268,7 @@ Status LaunchRemoteChromeSession(
Status LaunchDesktopChrome(
URLRequestContextGetter* context_getter,
- int port,
+ uint16 port,
scoped_ptr<PortReservation> port_reservation,
const SyncWebSocketFactory& socket_factory,
const Capabilities& capabilities,
@@ -432,7 +432,7 @@ Status LaunchDesktopChrome(
Status LaunchAndroidChrome(
URLRequestContextGetter* context_getter,
- int port,
+ uint16 port,
scoped_ptr<PortReservation> port_reservation,
const SyncWebSocketFactory& socket_factory,
const Capabilities& capabilities,
@@ -511,7 +511,7 @@ Status LaunchChrome(
capabilities, devtools_event_listeners, chrome);
}
- int port = 0;
+ uint16 port = 0;
scoped_ptr<PortReservation> port_reservation;
Status port_status(kOk);
« no previous file with comments | « chrome/test/base/testing_browser_process.cc ('k') | chrome/test/chromedriver/net/port_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698