chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/socket/udp_socket_unittest.cc ('k') | chrome/browser/extensions/app_background_page_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index a36a55b8f2c2da4a4dcbcd3f9b9131836796b7c4..17cbd055cb7c42a02eb9230d30370cb7457dacac 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -344,14 +344,14 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, ServerRedirectSingleProcess) {

ResultCatcher catcher;

GURL url(base::StringPrintf(

- "http://www.a.com:%d/"

+ "http://www.a.com:%u/"

"extensions/api_test/webnavigation/serverRedirectSingleProcess/a.html",

embedded_test_server()->port()));

ui_test_utils::NavigateToURL(browser(), url);

url = GURL(base::StringPrintf(

- "http://www.b.com:%d/server-redirect?http://www.b.com:%d/",

+ "http://www.b.com:%u/server-redirect?http://www.b.com:%u/",

embedded_test_server()->port(),

embedded_test_server()->port()));

@@ -559,14 +559,14 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, CrossProcessFragment) {

test_navigation_listener(),

embedded_test_server()->GetURL("/test3"),

"updateFragment()",

- base::StringPrintf("f.html?%d#foo", embedded_test_server()->port()));

+ base::StringPrintf("f.html?%u#foo", embedded_test_server()->port()));

// See crossProcessFragment/g.html.

DelayLoadStartAndExecuteJavascript call_script4(

test_navigation_listener(),

embedded_test_server()->GetURL("/test4"),

"updateFragment()",

- base::StringPrintf("g.html?%d#foo", embedded_test_server()->port()));

+ base::StringPrintf("g.html?%u#foo", embedded_test_server()->port()));

ASSERT_TRUE(RunExtensionTest("webnavigation/crossProcessFragment"))

<< message_;

@@ -614,7 +614,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Crash) {

ResultCatcher catcher;

GURL url(base::StringPrintf(

- "http://www.a.com:%d/"

+ "http://www.a.com:%u/"

"extensions/api_test/webnavigation/crash/a.html",

embedded_test_server()->port()));

ui_test_utils::NavigateToURL(browser(), url);

@@ -622,7 +622,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Crash) {

ui_test_utils::NavigateToURL(browser(), GURL(content::kChromeUICrashURL));

url = GURL(base::StringPrintf(

- "http://www.a.com:%d/"

+ "http://www.a.com:%u/"

"extensions/api_test/webnavigation/crash/b.html",

embedded_test_server()->port()));

ui_test_utils::NavigateToURL(browser(), url);