chrome/browser/devtools/browser_list_tabcontents_provider.cc - Issue 655063002: Use uint16 for port numbers more pervasively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/browser_list_tabcontents_provider.cc

Issue 655063002: Use uint16 for port numbers more pervasively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert bad change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/browser_list_tabcontents_provider.cc

diff --git a/chrome/browser/devtools/browser_list_tabcontents_provider.cc b/chrome/browser/devtools/browser_list_tabcontents_provider.cc

index 06fcd3a30fe8d4db392282d588bd9f37335a3c98..a975222fe24e86fe8dca28378febfa2fcc7df7df 100644

--- a/chrome/browser/devtools/browser_list_tabcontents_provider.cc

+++ b/chrome/browser/devtools/browser_list_tabcontents_provider.cc

@@ -21,8 +21,8 @@

namespace {

-const int kMinTetheringPort = 9333;

-const int kMaxTetheringPort = 9444;

+const uint16 kMinTetheringPort = 9333;

+const uint16 kMaxTetheringPort = 9444;

const int kBackLog = 10;

@@ -85,7 +85,7 @@ BrowserListTabContentsProvider::CreateSocketForTethering(

if (last_tethering_port_ == kMaxTetheringPort)

last_tethering_port_ = kMinTetheringPort;

- int port = ++last_tethering_port_;

+ uint16 port = ++last_tethering_port_;

*name = base::IntToString(port);

scoped_ptr<net::TCPServerSocket> socket(

new net::TCPServerSocket(nullptr, net::NetLog::Source()));