Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 655053002: Fix incorrect assumption about children's flexBasis (Closed)

Created:
6 years, 2 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 2 months ago
Reviewers:
cbiesinger
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Fix incorrect assumption about children's flexBasis The code to cache preferredMainAxisContentExtentForChild when possible and re-use to avoid forcing layout was broken in the case that a child's flex basis changed to cause it to be dependent on layout, triggering an assert in debug. Just pushing it down the normal path fixes the issue. BUG=366185 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183853

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
A LayoutTests/fast/flexbox/relayout-children-when-switching-direction.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/flexbox/relayout-children-when-switching-direction-expected.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
leviw_travelin_and_unemployed
6 years, 2 months ago (2014-10-14 21:57:06 UTC) #2
cbiesinger
Good catch, but can you also add a test that more specifically tests flexbox?
6 years, 2 months ago (2014-10-14 22:08:47 UTC) #3
leviw_travelin_and_unemployed
ptal!
6 years, 2 months ago (2014-10-16 00:01:09 UTC) #4
cbiesinger
lgtm. thanks!
6 years, 2 months ago (2014-10-17 00:16:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655053002/40001
6 years, 2 months ago (2014-10-17 01:47:36 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 04:06:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183853

Powered by Google App Engine
This is Rietveld 408576698