Fix view-source url creation logic

content/browser/browser_url_handler_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_url_handler_impl.h"
 
 #include "base/strings/string_util.h"
 #include "content/browser/frame_host/debug_urls.h"
 #include "content/browser/webui/web_ui_impl.h"
 #include "content/public/browser/content_browser_client.h"
@@ skipping 44 matching lines @@
     return true;
   }
   return false;
 }
 
 // Turns a non view-source URL into the corresponding view-source URL.
 static bool ReverseViewSource(GURL* url, BrowserContext* browser_context) {
   // No action necessary if the URL is already view-source:
   if (url->SchemeIs(kViewSourceScheme))
     return false;
-
-  url::Replacements<char> repl;
-  repl.SetScheme(kViewSourceScheme,
-                 url::Component(0, strlen(kViewSourceScheme)));
-  repl.SetPath(url->spec().c_str(), url::Component(0, url->spec().size()));
-  *url = url->ReplaceComponents(repl);
+  // Recreate the url with the view-source scheme.
+  *url = GURL(kViewSourceScheme + std::string(":") + url->spec());

[sky, 2014/10/14 19:56:31]

Doesn't gurl have the ability to replace parts of it? Specifically
ReplaceComponents?

[sgurun-gerrit only, 2014/10/14 21:02:52]

I could not see an easy way of doing it. Two possibilities that I can think of
are:
1. add 
repl.ClearQuery();
repl.ClearRequest();
after line 69 in previous version.
2. or add a std::string getPath() kind of a getter to GURL and then use it to
replace the path component. 

[joth, 2014/10/17 20:18:39]

Thanks for fixing my bug! (well, bug my cl exposed :)

worth adding some regression tests for ReverseViewSource with a couple of the
example URLs from the bug report?

[sgurun-gerrit only, 2014/10/17 20:35:35]

Rather then regression tests, I have written a unit test, which I think was more
appropriate in this case.
https://codereview.chromium.org/659153003/

[sgurun-gerrit only, 2014/10/17 20:37:39]

haha I think I read regression as integration tests :) yeah wrote a unit test.

   return true;
 }
 
 static bool DebugURLHandler(GURL* url, BrowserContext* browser_context) {
   // Circumvent processing URLs that the renderer process will handle.
   return IsRendererDebugURL(*url);
 }
 
 // static
 BrowserURLHandler* BrowserURLHandler::GetInstance() {
@@ skipping 53 matching lines @@
           return true;
       } else if (handler(&test_url, browser_context)) {
         return reverse_rewriter(url, browser_context);
       }
     }
   }
   return false;
 }
 
 }  // namespace content