Source/core/rendering/RenderLayer.cpp - Issue 655003005: [New Multicolumn] boundingBoxForCompositingOverlapTest() needs to use fragmentsBoundingBox().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 655003005: [New Multicolumn] boundingBoxForCompositingOverlapTest() needs to use fragmentsBoundingBox(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add tests for vertical-rl and vertical-lr. The verical-rl one fails currently. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index ba9c9160db2976b1d391d06894bc2f66cab7d88d..d41116170cb5d35191143df2bc7d42453d950789 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -2283,7 +2283,7 @@ LayoutRect RenderLayer::fragmentsBoundingBox(const RenderLayer* ancestorLayer) c

LayoutRect RenderLayer::boundingBoxForCompositingOverlapTest() const

{

- return overlapBoundsIncludeChildren() ? boundingBoxForCompositing() : flippedLogicalBoundingBox(logicalBoundingBox(), renderer());

+ return overlapBoundsIncludeChildren() ? boundingBoxForCompositing() : fragmentsBoundingBox(this);

}

static void expandRectForReflectionAndStackingChildren(const RenderLayer* ancestorLayer, RenderLayer::CalculateBoundsOptions options, LayoutRect& result)

« no previous file with comments | « LayoutTests/fast/multicol/vertical-rl/composited-relpos-overlapping-will-change-expected.html ('k') | no next file » | no next file with comments »