Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 655003004: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
danakj
CC:
asvitkine+watch_chromium.org, chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, Ilya Sherman, reveman, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. Also convert a few explicit invocations of the default scoped_ptr ctor to just use nullptr instead. BUG=423621 Committed: https://crrev.com/84b60296949265b42e9b54937563be58fdcc0b8c Cr-Commit-Position: refs/heads/master@{#299709}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M base/debug/trace_event_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_android.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/metrics/histogram.cc View 2 chunks +2 lines, -2 lines 1 comment Download
M base/metrics/sparse_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process/process_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_metrics_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
6 years, 2 months ago (2014-10-15 17:13:28 UTC) #2
danakj
Can you mention the nullptr changes in the patch description? LGTM https://codereview.chromium.org/655003004/diff/1/base/metrics/histogram.cc File base/metrics/histogram.cc (right): ...
6 years, 2 months ago (2014-10-15 17:20:08 UTC) #3
dcheng
On 2014/10/15 at 17:20:08, danakj wrote: > Can you mention the nullptr changes in the ...
6 years, 2 months ago (2014-10-15 17:29:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/655003004/1
6 years, 2 months ago (2014-10-15 17:31:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 17:48:01 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 17:48:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84b60296949265b42e9b54937563be58fdcc0b8c
Cr-Commit-Position: refs/heads/master@{#299709}

Powered by Google App Engine
This is Rietveld 408576698