Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: LayoutTests/inspector/sources/debugger/promise-tracker.html

Issue 654983002: Fix flaky inspector/sources/debugger/promise-tracker.html test. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/sources/debugger/promise-tracker.html
diff --git a/LayoutTests/inspector/sources/debugger/promise-tracker.html b/LayoutTests/inspector/sources/debugger/promise-tracker.html
index f50dff27bb7a0c4e2f8ab1149fe5f0e44b2b76ac..38c0f9afc785589ead09b3feeb56a44ae98664dd 100644
--- a/LayoutTests/inspector/sources/debugger/promise-tracker.html
+++ b/LayoutTests/inspector/sources/debugger/promise-tracker.html
@@ -46,7 +46,7 @@ var test = function ()
{
var t1 = x.creationTime || 0;
var t2 = y.creationTime || 0;
- return t1 - t2;
+ return t1 - t2 || x.id - y.id;
}
InspectorTest.assertEquals(3, response.length, "FAIL: Invalid number of Promises.");
@@ -73,7 +73,8 @@ var test = function ()
output.push(promiseInfo);
}
- InspectorTest.assertTrue(response[0].settlementTime <= response[1].settlementTime && !response[2].settlementTime, "FAIL: invalid Promise settlement time.");
+ InspectorTest.assertGreaterOrEqual(response[1].settlementTime, response[0].settlementTime, "FAIL: invalid Promise settlement time.");
+ InspectorTest.assertTrue(!response[2].settlementTime, "FAIL: a pending Promise should not have settlement time.");
InspectorTest.addResults(output);
@@ -88,7 +89,8 @@ var test = function ()
RuntimeAgent.getProperties(response.objectId, didGetProperties);
}
- function didGetProperties(error, properties, internalProperties) {
+ function didGetProperties(error, properties, internalProperties)
+ {
InspectorTest.assertTrue(!error, "FAIL: " + error);
InspectorTest.assertTrue(internalProperties && internalProperties.length > 0, "FAIL: no internal properties.");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698