Source/web/tests/WebFrameTest.cpp - Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 654953002: Navigation transitions (web to native app): Get names and rects of transition elements (Step 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 84c623244f0d7c561266a6122d1fd6ea83d56203..3b3606b9522d8d0acacdb67d62eb9b714824b42a 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -6864,7 +6864,12 @@ public:

, m_provisionalLoadCount(0)

, m_wasLastProvisionalLoadATransition(false) { }

- virtual void addNavigationTransitionData(const WebString& allowedDestinationOrigin, const WebString& selector, const WebString& markup) override

+ virtual void addNavigationTransitionData(

+ const WebString& allowedDestinationOrigin,

+ const WebString& selector,

+ const WebString& markup,

+ const WebVector<WebString>& names,

+ const WebVector<WebRect>& rects) override

{

m_navigationalDataReceivedCount++;

}

« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »