Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/core/dom/Document.cpp

Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 69ac933bf334b8c45e8b1a1b1cc96dcf5aafa332..c013c374c3ab332bae5d6fa3930641560e573022 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -60,6 +60,7 @@
 #include "core/dom/AddConsoleMessageTask.h"
 #include "core/dom/Attr.h"
 #include "core/dom/CDATASection.h"
+#include "core/dom/ClientRect.h"
 #include "core/dom/Comment.h"
 #include "core/dom/ContextFeatures.h"
 #include "core/dom/DOMImplementation.h"
@@ -5616,13 +5617,15 @@ void Document::getTransitionElementData(Vector<TransitionElementData>& elementDa
         if (!nodeListLength)
             continue;
 
+        TransitionElementData newElements;
         StringBuilder markup;
         for (unsigned nodeIndex = 0; nodeIndex < nodeListLength; ++nodeIndex) {
             Element* element = elementList->item(nodeIndex);
             markup.append(createStyledMarkupForNavigationTransition(element));
+            newElements.rects.append(element->boundsInRootViewSpace());
+            newElements.names.append(element->getIdAttribute().string());

[esprehn, 2014/10/24 21:59:11]

Using querySelector doesn't mean that these have ids. I don't understand what
you're saying. I can querySelector for a thing like "div + div", and select an
element with no attributes at all. I can similarly select .foo and get something
with class names and no ids. This can't work.

[Zhen Wang, 2014/10/27 14:14:45]

Checking if the element has ID now. Using empty string if it does not have ID.

         }
 
-        TransitionElementData newElements;
         newElements.scope = metaElementContents.substring(firstSemicolon + 1).stripWhiteSpace();
         newElements.selector = selector;
         newElements.markup = markup.toString();