Navigation transitions (web to native app): Get names and rects of transition elements (Step 2)

Source/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 460 matching lines @@
     navigationInfo.extraData = ds->extraData();
     navigationInfo.navigationType = ds->navigationType();
     navigationInfo.defaultPolicy = static_cast<WebNavigationPolicy>(policy);
     navigationInfo.isRedirect = ds->isRedirect();
     navigationInfo.isTransitionNavigation = isTransitionNavigation;
 
     WebNavigationPolicy webPolicy = m_webFrame->client()->decidePolicyForNavigation(navigationInfo);
     return static_cast<NavigationPolicy>(webPolicy);
 }
 
-void FrameLoaderClientImpl::dispatchAddNavigationTransitionData(const String& allowedDestinationOrigin, const String& selector, const String& markup)
+void FrameLoaderClientImpl::dispatchAddNavigationTransitionData(
+    const String& allowedDestinationOrigin, const String& selector,
+    const String& markup, const Vector<String>& names,

[sof, 2014/10/24 15:17:14]

Ditto

[Zhen Wang, 2014/10/27 14:14:45]

Using struct now.

+    const Vector<IntRect>& rects)
 {
-    if (m_webFrame->client())
-        m_webFrame->client()->addNavigationTransitionData(allowedDestinationOrigin, selector, markup);
+    if (m_webFrame->client()) {
+        m_webFrame->client()->addNavigationTransitionData(
+            allowedDestinationOrigin, selector, markup, names, rects);

[sof, 2014/10/24 15:17:14]

Keep line length style as-was?

[Zhen Wang, 2014/10/27 14:14:45]

This will be changed into using struct in later CLs.

By the way, I see other places also using multiple line style. Are we guided to
use single line statements only?

+    }
 }
 
 void FrameLoaderClientImpl::dispatchWillRequestResource(FetchRequest* request)
 {
     if (m_webFrame->client()) {
         WebCachedURLRequest urlRequest(request);
         m_webFrame->client()->willRequestResource(m_webFrame, urlRequest);
     }
 }
 
@@ skipping 358 matching lines @@
         m_webFrame->client()->didAbortLoading(m_webFrame);
 }
 
 void FrameLoaderClientImpl::dispatchDidChangeManifest()
 {
     if (m_webFrame->client())
         m_webFrame->client()->didChangeManifest(m_webFrame);
 }
 
 } // namespace blink