Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 654933004: Remove now-unnecessary VectorTraits specializations. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, rune+blink, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, rwlbuis, jfernandez, zoltan1, Manuel Rego, darktears, blink-reviews-rendering, svillar, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, mkwst+moarreviews_chromium.org, ed+blinkwatch_opera.com, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove now-unnecessary VectorTraits specializations. Following r183947's improvements to VectorTraits accuracy, remove some redundant specializations. R=tkent BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184046

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated to just use improved VectorTraits.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -71 lines) Patch
M Source/core/css/CSSGradientValue.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/events/NodeEventContext.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/html/canvas/WebGLVertexArrayObjectOES.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 2 chunks +0 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderTableSection.h View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
haraken
Looks like there is a compile error?
6 years, 2 months ago (2014-10-15 05:17:31 UTC) #2
sof
On 2014/10/15 05:17:31, haraken wrote: > Looks like there is a compile error? Quite a ...
6 years, 2 months ago (2014-10-15 05:22:31 UTC) #3
haraken
+tkent-san Looks good but wtf/ experts would want to confirm. https://codereview.chromium.org/654933004/diff/1/Source/core/rendering/RenderTableSection.h File Source/core/rendering/RenderTableSection.h (right): https://codereview.chromium.org/654933004/diff/1/Source/core/rendering/RenderTableSection.h#newcode327 ...
6 years, 2 months ago (2014-10-15 05:26:35 UTC) #5
sof
Thanks, but only meant to show what's doable later, and not push for it to ...
6 years, 2 months ago (2014-10-15 05:29:57 UTC) #6
tkent
not lgtm. type_traits is a C++11 library feature. We can't use it yet.
6 years, 2 months ago (2014-10-15 05:40:02 UTC) #7
sof
As r183947 sidestepped <type_traits> usage and used frontend intrinsics (that implement <type_traits>) instead, I think ...
6 years, 2 months ago (2014-10-20 07:06:00 UTC) #8
tkent
lgtm
6 years, 2 months ago (2014-10-21 00:20:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654933004/20001
6 years, 2 months ago (2014-10-21 05:05:56 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 07:06:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184046

Powered by Google App Engine
This is Rietveld 408576698