snapshot/exception_snapshot_mac.h - Issue 654933002: Use exactly one of final, override, and virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/exception_snapshot_mac.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/exception_snapshot_mac.h

diff --git a/snapshot/exception_snapshot_mac.h b/snapshot/exception_snapshot_mac.h

index 7f6fb0b18bfb207e556dd74f079138150c7522e1..f0fc8e67ff35b1aa3cff01f01c67574e8d36b92f 100644

--- a/snapshot/exception_snapshot_mac.h

+++ b/snapshot/exception_snapshot_mac.h

@@ -60,12 +60,12 @@ class ExceptionSnapshotMac final : public ExceptionSnapshot {

// ExceptionSnapshot:

- virtual const CPUContext* Context() const override;

- virtual uint64_t ThreadID() const override;

- virtual uint32_t Exception() const override;

- virtual uint32_t ExceptionInfo() const override;

- virtual uint64_t ExceptionAddress() const override;

- virtual const std::vector<uint64_t>& Codes() const override;

+ const CPUContext* Context() const override;

+ uint64_t ThreadID() const override;

+ uint32_t Exception() const override;

+ uint32_t ExceptionInfo() const override;

+ uint64_t ExceptionAddress() const override;

+ const std::vector<uint64_t>& Codes() const override;

private:

#if defined(ARCH_CPU_X86_FAMILY)

« no previous file with comments | « minidump/minidump_writable_test.cc ('k') | snapshot/memory_snapshot_mac.h » ('j') | no next file with comments »